-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVM][NewPM] Add a C API for setting the PassBuilder AA pipeline. #102482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one nit
@@ -28,11 +29,14 @@ class LLVMPassBuilderOptions { | |||
public: | |||
explicit LLVMPassBuilderOptions( | |||
bool DebugLogging = false, bool VerifyEach = false, | |||
const char *AAPipeline = nullptr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LLVMPassBuilderOptions
is never constructed with params. the constructor shouldn't take any arguments.
I'll do this in a followup patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
da39b88
to
ce748da
Compare
I don't have commit bit, so anybody feel free to land this. |
…lvm#102482) This PR adds a field to the pass builder options struct, `AAPipeline`, exposed through a C API `LLVMPassBuilderOptionsSetAAPipeline`, that is used to set an alias analysis pipeline to be used in stead of the default one. x-ref https://discourse.llvm.org/t/newpm-c-api-questions/80598
This PR adds a field to the pass builder options struct,
AAPipeline
, exposed through a C APILLVMPassBuilderOptionsSetAAPipeline
, that is used to set an alias analysis pipeline to be used in stead of the default one.cc @nikic
x-ref https://discourse.llvm.org/t/newpm-c-api-questions/80598