[LLVM][NewPM] Add a C API for setting the PassBuilder AA pipeline. #102482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeubanks
reviewed
Aug 12, 2024
| @@ -28,11 +29,14 @@ class LLVMPassBuilderOptions { | |||
| public: | |||
| explicit LLVMPassBuilderOptions( | |||
| bool DebugLogging = false, bool VerifyEach = false, | |||
| const char *AAPipeline = nullptr, | |||
There was a problem hiding this comment.
LLVMPassBuilderOptions is never constructed with params. the constructor shouldn't take any arguments.
I'll do this in a followup patch
nikic
reviewed
Aug 13, 2024
maleadt
force-pushed
the
newpm_c_aapipeline
branch
from
da39b88
to
ce748da
Compare
|
I don't have commit bit, so anybody feel free to land this. |
bwendling
pushed a commit
to bwendling/llvm-project
that referenced
this pull request
Aug 15, 2024
…lvm#102482) This PR adds a field to the pass builder options struct, `AAPipeline`, exposed through a C API `LLVMPassBuilderOptionsSetAAPipeline`, that is used to set an alias analysis pipeline to be used in stead of the default one. x-ref https://discourse.llvm.org/t/newpm-c-api-questions/80598
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a field to the pass builder options struct,
AAPipeline, exposed through a C APILLVMPassBuilderOptionsSetAAPipeline, that is used to set an alias analysis pipeline to be used in stead of the default one.cc @nikic
x-ref https://discourse.llvm.org/t/newpm-c-api-questions/80598